Comments on: Number Format - Thousand Separator in AS3

By: Flassari

Flassari — Thu, 15 Apr 2010 22:15:34 +0000

The formatting was done on purpose. I know it’s massively compressed and horrible to read, but it’s supposed to be small and convenient to paste into timeline or code. There were other resources which had dedicated classes which are easily changeable and commented (like for beginners) at the time I made this (and still are), but I didn’t want a whole class when I just wanted something quick and small to insert into the timeline.
I also don’t recommend this code for mass number processing since it is not at all optimized for speed, only compactness.

By: bractar

bractar — Thu, 15 Apr 2010 21:44:18 +0000

nice functionality but I hate your formatting. It isn’t clear enough to be updated easily. You don’t need to show that you can program like a nasa guy when you give a function on the web. Most people who will use your function will be beginners…
But thank you for sharing it

By: DanielSig

DanielSig — Wed, 30 Dec 2009 16:55:25 +0000

Hey, I added a little tweak of mine to your function. What it does is that it indents the returning string with indentUnit so that the length of the string minus decimals becomes forceLength. This can be useful when you intend to align a vertical list of numbers so that the decimal points are in a straight line. Note: unless you specify the forceLength parameter as a uint higher than 0, this function behaves just like the original function made by Flassari.

function numberFormat(number:*, maxDecimals:int = 2, forceDecimals:Boolean = false, siStyle:Boolean = true, forceLength:uint = 0, indentUnit:String = " "):String {
	var i:int = 0, inc:Number = Math.pow(10, maxDecimals), str:String = String(Math.round(inc * Number(number))/inc), indent:String = "";
	var hasSep:Boolean = str.indexOf(".") == -1, sep:int = hasSep ? str.length : str.indexOf(".");
	var ret:String = (hasSep && !forceDecimals ? "" : (siStyle ? "," : ".")) + str.substr(sep+1);
	if (forceDecimals) for (var j:int = 0; j <= maxDecimals - (str.length - (hasSep ? sep-1 : sep)); j++) ret += "0";
	while (i + 3 < (str.substr(0, 1) == "-" ? sep-1 : sep)) ret = (siStyle ? "." : ",") + str.substr(sep - (i += 3), 3) + ret;
	if(forceLength != 0) for(j = sep + i / 3; j < forceLength; j++) indent += indentUnit;
	return indent + str.substr(0, sep - i) + ret;
}

By: Torben

Torben — Tue, 24 Nov 2009 11:24:32 +0000

Great, thanks Flassari

By: Flassari

Flassari — Fri, 20 Nov 2009 13:31:41 +0000

Torben, I found the error you were talking about; it only happened when you passed in whole numbers.
It’s been fixed now, thanks for spotting it =)

By: Torben

Torben — Fri, 20 Nov 2009 13:00:07 +0000

I don’t see what was wrong with your original Deciaml code. When I test it your first line works - the second ads one decimal too many.

By: nizzle

nizzle — Sat, 31 Oct 2009 10:33:28 +0000

Thanks, I was just looking for something like this. Nice code, also.

By: Flassari

Flassari — Wed, 21 Oct 2009 10:11:16 +0000

No, that's what the siStyle property is for, you can actually choose the metric SI style (default true because of majority) or non-SI style (false) that's in use in mostly Burma (Myanmar), Liberia, and the United States.

By: John

John — Tue, 20 Oct 2009 21:37:11 +0000

You’ve also got the comma and decimal around the wrong way.

By: Flassari

Flassari — Fri, 09 Oct 2009 18:06:46 +0000

Aaah, you're absolutely right! It's fixed now. To hold onto compactness I changed

for (var j:int = 0; j < maxDecimals - (str.length - sep); j++)

for (var j:int = 0; j <= maxDecimals - (str.length - sep); j++)

Thanks for spotting that =)